This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Simplify features build #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be rebased, and then I can take a look 😄 Thanks for answering part of my previous question heh. |
|
@securityinsanity done |
|
Hey sorry can you rebase again? 😅 (no need to comment when you're done, I'll just checkback later today 😄 ) |
This was referenced Feb 24, 2020
Closed
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR builds on #23 and provide a more feature-proof fix of the problem.
Motivation
The source of #23 is that there was code duplication so fixes were only applied to one of the variants.
This change move the conditional check for
v1&v2in the builder inside the methods instead of duplicating themTest Plan (required)
I ran both
cargo buildandcargo testwith/withoutv1&v2(There are still a few unused things warning when only one of them is present but they build and pass tests)