Base64 newlines #18
Closed
Base64 newlines #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after verifying signatures, we build a list of "trusted roots" by walking up to the elements referenced by the xml signatures. then we only query against those trusted roots for details of the assertion.
because we have to use xmlSecAddIDs to get xmlsec to be able to dereference signature references in SAML responses, a specially crafted document with duplicate IDs can fool xmlsec into validating a signature outside of the ancestry of the reference. this provides an attack vector for injecting an unsigned assertion. the solution is to catch the error thrown when xmlsec sees the duplicate ID and immediately treat the response as invalid when this occurs.
|
apparently this is the wrong branch :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.