Fixed build step in Dockerfiles #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The target `make linux` which resulted in `/bin/linux/amd64/kubeval` was likely used before. This target no longer exists, so switching over to using `make build` (which Dockerfile.acceptance already uses), which produces a binary at `/bin/kubeval`
|
#122 seems related |
|
Thanks, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was messing around with the project and couldn't build the Dockerfiles. My understanding is that they were not updated when the make targets for building was changed from
make linux=/bin/linux/amd64/kubevaltomake build=/bin/kubeval(during the introduction of GoReleaser?). This PR updates the build step in the Dockerfiles.make docker,make acceptanceandmake docker-offlinenow work.Maybe I'm overlooking something, but anyway here's a PR in case it's a valid fix.