fix: TAP Schema treats SKIP as a directive, at the end of the line #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playing around with tap-to-junit vlaidations I found that the only safe way to get the skips parsed was to use capitalized `# SKIP` with the space after the description. Technically lowercase seems to be allowed but the majority of the schema's examples show capitalized. In the schema it also says any explanation of why it was skipped should go after the `# SKIP`, but the description of the test still goes to the left. https://testanything.org/tap-version-13-specification.html
|
thanks! |
|
@carlossg any idea when the next release might be? |
|
not sure I can cut one, if @garethr doesn't do it I'll give it a try |
carlossg
added a commit
that referenced
this pull request
Mar 29, 2021
|
this test is failing I don't know what happened in CI when it was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing around with tap-to-junit vlaidations I found that the only safe way
to get the skips parsed was to use capitalized
# SKIPwith the space after the description.Technically lowercase seems to be allowed but the majority of the schema's
examples show capitalized.
https://testanything.org/tap-version-13-specification.html
In the schema it also says any explanation of why it was skipped should go
after the
# SKIP, but the description of the test still goes to the left.I wasn't sure what all would be necessary but it would be kewl to have the
returned status value for the reason they were skipped map to a string
to append to the line.