Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library linking on macOS #77

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Fix library linking on macOS #77

merged 4 commits into from
Aug 22, 2022

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Aug 22, 2022

Synopsis

MacOS has some strange behavior for library loading. Path of library is write in final dylib (but by default this path is absolute path of library on local machine), so we need to pass some rustc flag which will fix it. When we're not doing it - built application won't work on other machines, except machine on which this library was built.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Related to project toolchain labels Aug 22, 2022
@evdokimovs evdokimovs self-assigned this Aug 22, 2022
@evdokimovs
Copy link
Contributor Author

FCM

Fix library linking on macOS (#77)

@alexlapa alexlapa requested a review from tyranron August 22, 2022 14:06
@tyranron tyranron removed the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Aug 22, 2022
@tyranron tyranron merged commit 89a4dfb into master Aug 22, 2022
@tyranron tyranron deleted the fix-macos-linking branch August 22, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants