Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bluetooth headset detection on Android #96

Merged
merged 9 commits into from
Feb 8, 2023
Merged

Fix Bluetooth headset detection on Android #96

merged 9 commits into from
Feb 8, 2023

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Dec 6, 2022 •
edited by tyranron

Depends on #77

Synopsis

This PR adds support for isFailed flag in MediaDeviceInfo. This flag was added to the flutter_webrtc for automatic Bluetooth headset reconnection feature.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform labels Dec 6, 2022
@evdokimovs evdokimovs self-assigned this Dec 6, 2022
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Dec 6, 2022 •
edited by tyranron

FCM

Add `MediaDeviceInfo.isFailed()` Dart API (#96)

@tyranron tyranron force-pushed the master branch 5 times, most recently from 8e9b1ab to d63980d Compare December 22, 2022 15:03
@tyranron tyranron force-pushed the master branch 2 times, most recently from 2afebeb to 241d406 Compare January 28, 2023 12:58
@alexlapa alexlapa self-requested a review February 8, 2023 09:07
@alexlapa alexlapa marked this pull request as ready for review February 8, 2023 09:09
@tyranron tyranron added the enhancement Improvement of existing features or bugfix label Feb 8, 2023
@tyranron tyranron changed the title Draft: Fix Bluetooth headset detection on Android Fix Bluetooth headset detection on Android Feb 8, 2023
@tyranron tyranron enabled auto-merge (squash) February 8, 2023 17:51
@tyranron tyranron merged commit 70347b0 into master Feb 8, 2023
@tyranron tyranron deleted the fix-bluetooth-headset branch February 8, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evdokimovs @tyranron @alexlapa