This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Return enums instead of strings in Jason's exported functions #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Как-то так повелось, что enum'ы в js'ку мы возвращаем в виде строк, так как решили что для js'ки так будет более идиоматично. При этом в функциях которые принимают enum'ы, мы принимаем enum'ы. Хочется достичь консистентности: мы или и принимаем и возвращаем enum'ы, или мы и принимаем и возвращаем стринги.
Склоняюсь к первому варианту.
Solution
MediaKind
andMediaSourceKind
enums.InputDeviceInfo.kind -> String => InputDeviceInfo.kind -> MediaKind
MediaTrack.kind -> String => MediaTrack.kind -> MediaKind
MediaTrack.media_source_kind -> String => MediaTrack.media_source_kind -> MediaSourceKind
Audio
andVideo
variants:InputDeviceKind
,TransceiverKind
andMediaTrackKind
. Get rid of those in favor ofMediaKind
enum.Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed