Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to phase and health controllers #1015

Closed
wants to merge 2 commits into from
Closed

Refactor to phase and health controllers #1015

wants to merge 2 commits into from

Conversation

int128
Copy link
Owner

@int128 int128 commented Dec 31, 2023

No description provided.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 1, 2024

diff

  • config/default/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml (New)
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
  • e2e_test/controller/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml (New)
  • e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml

config/default/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml

--- /dev/null
+++ b/tmp/kustomize-action-yb0e32/config/default/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml
@@ -0,0 +1,48 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  annotations:
+    controller-gen.kubebuilder.io/version: v0.12.0
+  name: notifications.argocdcommenter.int128.github.io
+spec:
+  group: argocdcommenter.int128.github.io
+  names:
+    kind: Notification
+    listKind: NotificationList
+    plural: notifications
+    singular: notification
+  scope: Namespaced
+  versions:
+  - name: v1
+    schema:
+      openAPIV3Schema:
+        description: Notification is the Schema for the notifications API
+        properties:
+          apiVersion:
+            description: 'APIVersion defines the versioned schema of this representation
+              of an object. Servers should convert recognized schemas to the latest
+              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+            type: string
+          kind:
+            description: 'Kind is a string value representing the REST resource this
+              object represents. Servers may infer this from the endpoint the client
+              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+            type: string
+          metadata:
+            type: object
+          spec:
+            description: NotificationSpec defines the desired state of Notification
+            type: object
+          status:
+            description: NotificationStatus defines the observed state of Notification
+            properties:
+              commentState:
+                type: string
+              deploymentState:
+                type: string
+            type: object
+        type: object
+    served: true
+    storage: true
+    subresources:
+      status: {}

config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml

--- a/tmp/kustomize-action-yVzLyf/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
+++ b/tmp/kustomize-action-yb0e32/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
@@ -3,32 +3,6 @@ kind: ClusterRole
 metadata:
   name: argocd-commenter-manager-role
 rules:
-- apiGroups:
-  - argocdcommenter.int128.github.io
-  resources:
-  - applicationhealths
-  verbs:
-  - create
-  - delete
-  - get
-  - list
-  - patch
-  - update
-  - watch
-- apiGroups:
-  - argocdcommenter.int128.github.io
-  resources:
-  - applicationhealths/finalizers
-  verbs:
-  - update
-- apiGroups:
-  - argocdcommenter.int128.github.io
-  resources:
-  - applicationhealths/status
-  verbs:
-  - get
-  - patch
-  - update
 - apiGroups:
   - argoproj.io
   resources:

e2e_test/controller/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml

--- /dev/null
+++ b/tmp/kustomize-action-yb0e32/e2e_test/controller/apiextensions.k8s.io_v1_customresourcedefinition_notifications.argocdcommenter.int128.github.io.yaml
@@ -0,0 +1,48 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  annotations:
+    controller-gen.kubebuilder.io/version: v0.12.0
+  name: notifications.argocdcommenter.int128.github.io
+spec:
+  group: argocdcommenter.int128.github.io
+  names:
+    kind: Notification
+    listKind: NotificationList
+    plural: notifications
+    singular: notification
+  scope: Namespaced
+  versions:
+  - name: v1
+    schema:
+      openAPIV3Schema:
+        description: Notification is the Schema for the notifications API
+        properties:
+          apiVersion:
+            description: 'APIVersion defines the versioned schema of this representation
+              of an object. Servers should convert recognized schemas to the latest
+              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+            type: string
+          kind:
+            description: 'Kind is a string value representing the REST resource this
+              object represents. Servers may infer this from the endpoint the client
+              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+            type: string
+          metadata:
+            type: object
+          spec:
+            description: NotificationSpec defines the desired state of Notification
+            type: object
+          status:
+            description: NotificationStatus defines the observed state of Notification
+            properties:
+              commentState:
+                type: string
+              deploymentState:
+                type: string
+            type: object
+        type: object
+    served: true
+    storage: true
+    subresources:
+      status: {}

e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml

--- a/tmp/kustomize-action-yVzLyf/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
+++ b/tmp/kustomize-action-yb0e32/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
@@ -3,32 +3,6 @@ kind: ClusterRole
 metadata:
   name: argocd-commenter-manager-role
 rules:
-- apiGroups:
-  - argocdcommenter.int128.github.io
-  resources:
-  - applicationhealths
-  verbs:
-  - create
-  - delete
-  - get
-  - list
-  - patch
-  - update
-  - watch
-- apiGroups:
-  - argocdcommenter.int128.github.io
-  resources:
-  - applicationhealths/finalizers
-  verbs:
-  - update
-- apiGroups:
-  - argocdcommenter.int128.github.io
-  resources:
-  - applicationhealths/status
-  verbs:
-  - get
-  - patch
-  - update
 - apiGroups:
   - argoproj.io
   resources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant