Upgrade from kubebuilder v3.10.0 to v3.11.0 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
int128
force-pushed
the
upgrade-kubebuilder-v3.11.0
branch
from
1165d3c
to
b42152e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
diff
config/default/apiextensions.k8s.io_v1_customresourcedefinition_proxies.ktunnels.int128.github.io.yaml--- a/tmp/kustomize-action-llXuta/config/default/apiextensions.k8s.io_v1_customresourcedefinition_proxies.ktunnels.int128.github.io.yaml
+++ b/tmp/kustomize-action-IpcULu/config/default/apiextensions.k8s.io_v1_customresourcedefinition_proxies.ktunnels.int128.github.io.yaml
@@ -2,8 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.11.3
- creationTimestamp: null
+ controller-gen.kubebuilder.io/version: v0.12.0
name: proxies.ktunnels.int128.github.io
spec:
group: ktunnels.int128.github.io
@@ -64,7 +63,8 @@ spec:
defined in spec.resourceClaims, that are used by
this container. \n This is an alpha field and requires
enabling the DynamicResourceAllocation feature gate.
- \n This field is immutable."
+ \n This field is immutable. It can only be set for
+ containers."
items:
description: ResourceClaim references one entry
in PodSpec.ResourceClaims.
@@ -103,7 +103,8 @@ spec:
of compute resources required. If Requests is omitted
for a container, it defaults to Limits if that is
explicitly specified, otherwise to an implementation-defined
- value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
+ value. Requests cannot exceed Limits. More info:
+ https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
type: object
type: objectconfig/default/apiextensions.k8s.io_v1_customresourcedefinition_tunnels.ktunnels.int128.github.io.yaml--- a/tmp/kustomize-action-llXuta/config/default/apiextensions.k8s.io_v1_customresourcedefinition_tunnels.ktunnels.int128.github.io.yaml
+++ b/tmp/kustomize-action-IpcULu/config/default/apiextensions.k8s.io_v1_customresourcedefinition_tunnels.ktunnels.int128.github.io.yaml
@@ -2,8 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.11.3
- creationTimestamp: null
+ controller-gen.kubebuilder.io/version: v0.12.0
name: tunnels.ktunnels.int128.github.io
spec:
group: ktunnels.int128.github.ioconfig/default/apps_v1_deployment_ktunnels-controller-manager.yaml--- a/tmp/kustomize-action-llXuta/config/default/apps_v1_deployment_ktunnels-controller-manager.yaml
+++ b/tmp/kustomize-action-IpcULu/config/default/apps_v1_deployment_ktunnels-controller-manager.yaml
@@ -23,29 +23,13 @@ spec:
labels:
control-plane: controller-manager
spec:
- affinity:
- nodeAffinity:
- requiredDuringSchedulingIgnoredDuringExecution:
- nodeSelectorTerms:
- - matchExpressions:
- - key: kubernetes.io/arch
- operator: In
- values:
- - amd64
- - arm64
- - ppc64le
- - s390x
- - key: kubernetes.io/os
- operator: In
- values:
- - linux
containers:
- args:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- --v=0
- image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.1
+ image: gcr.io/kubebuilder/kube-rbac-proxy:v0.14.1
name: kube-rbac-proxy
ports:
- containerPort: 8443config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-manager-role.yaml--- a/tmp/kustomize-action-llXuta/config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-manager-role.yaml
+++ b/tmp/kustomize-action-IpcULu/config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-manager-role.yaml
@@ -1,7 +1,6 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
- creationTimestamp: null
name: ktunnels-manager-role
rules:
- apiGroups:
|
int128
commented
Dec 29, 2023
| @@ -233,7 +231,7 @@ func (r *ProxyReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| Watches( | |||
| // watch tunnel(s) of a proxy | |||
| // https://book.kubebuilder.io/reference/watching-resources/externally-managed.html | |||
| &source.Kind{Type: &ktunnelsv1.Tunnel{}}, | |||
| &ktunnelsv1.Tunnel{}, | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick int128/kubebuilder-updates@e503579