Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests on Windows #761

Merged
merged 16 commits into from
Mar 19, 2024
Merged

Conversation

kadykov
Copy link
Contributor

@kadykov kadykov commented Sep 5, 2023

The aim of this PR is to improve automatic test coverage of the CI actions by launching the same tests on Linux and Windows

Fixes #760

@martindurant
Copy link
Member

This requires #759 to pass?

@kadykov
Copy link
Contributor Author

kadykov commented Sep 5, 2023

Yes, but I'm afraid it is not sufficient.
In any case, I think it is better to launch the tests on both platforms.

@martindurant
Copy link
Member

I only see a couple of path-related failures, and I presume your other PR fixes at least one of them

@martindurant
Copy link
Member

OK, just the one failure. Will you have the chance to track this down?

@kadykov
Copy link
Contributor Author

kadykov commented Sep 5, 2023

Yes, I have to check once agian #743

@kadykov kadykov mentioned this pull request Sep 11, 2023
@kadykov kadykov mentioned this pull request Oct 26, 2023
@kadykov
Copy link
Contributor Author

kadykov commented Mar 13, 2024

As far as I understand, using postgresql fixture from pytest-postgresql is not fully supported on Windows, so I skipped these tests on Windows.

@martindurant
Copy link
Member

Seems like we should also posixiify the sqlite_with_data path in the duckDB test. Not sure if the reader should do that.

@kadykov
Copy link
Contributor Author

kadykov commented Mar 14, 2024

I agree, that we should not posixify the path in the DuckDB reader.

The problem was not with the posixification, but with the protocol extraction, that we also should not do there.

Copy link
Member

@martindurant martindurant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions.

intake/readers/readers.py Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
@kadykov
Copy link
Contributor Author

kadykov commented Mar 19, 2024

I combined Windows and Linux test jobs with a matrix.
Now this PR is ready to be merged.

@martindurant martindurant merged commit b39ecfc into intake:master Mar 19, 2024
11 checks passed
@kadykov kadykov deleted the windows-tests-CI branch March 19, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests on Windows to CI github actions
2 participants