-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tests on Windows #761
Conversation
This requires #759 to pass? |
Yes, but I'm afraid it is not sufficient. |
I only see a couple of path-related failures, and I presume your other PR fixes at least one of them |
OK, just the one failure. Will you have the chance to track this down? |
Yes, I have to check once agian #743 |
As far as I understand, using |
Seems like we should also posixiify the |
I agree, that we should not posixify the path in the DuckDB reader. The problem was not with the posixification, but with the protocol extraction, that we also should not do there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small suggestions.
I combined Windows and Linux test jobs with a |
The aim of this PR is to improve automatic test coverage of the CI actions by launching the same tests on Linux and Windows
Fixes #760