Fix get_dir() behavior on Windows #763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
reviewed
Sep 6, 2023
| # leave the path without '/' in the end | ||
| return f"{protocol}://{dirname}" | ||
| # get absolute path, convert to posix and add '/' in the end | ||
| return f"{os.path.abspath(dirname).replace(os.sep, r'/')}/" |
There was a problem hiding this comment.
Will this not produce the OS-dependent version of the path?
I wonder whether fsspec.core.url_to_fs might be a more appropriate function for this job.
There was a problem hiding this comment.
I think it would be quite challenging due to its strange behavior.
I have prepared another solution #768
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
get_dir()behavior on the Windows platform.It is supposed to replace #743, and should be compatible with #761.
Function
get_dir()is rewritten according to the tests intest_local.test_get_dir(), but the expected behavior is quite weird.It looks like the real problem is somewhere else, but we are trying to patch it here.