-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Datasource Custom query parameters (customQueryParame… #350
Add support for Datasource Custom query parameters (customQueryParame… #350
Conversation
Hi @kirchknopfc. Thanks for your PR. I'm waiting for a integr8ly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pb82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comment, once that's addressed I'm happy to merge this in 👍
sure was my misstake Co-authored-by: Hubert Stefanski <35736504+HubertStefanski@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm, thanks for contributing @kirchknopfc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HubertStefanski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
Grafana has an option to define Custom query parameters on an Prometheus data source.
Basically, it means that this query parameter add to the Promtheus or Thanos queries.
The query parameter example is required if OpenShift's user-defined monitoring is used as Prometheus datasource.
The OpenShift thanos-querier (https://thanos-querier.openshift-monitoring.svc.cluster.local:9092) needed the URL parameter "namespace=yournamespace" in the query as parameter.
The option on the Prometheus datasource is called "Custom query parameters" (customQueryParameters) in the section "Misc":
The proposed change adds support for set the Custom query parameters via the GrafanaDatasource CRD.
Relevant issues/tickets
PR #309
Type of change
Checklist
This change requires a documentation update
I've added an example below, you might want to include it in the documentation. But not all option are documented
I have added a test case that will be used to verify my changes
Verified independently on a cluster by reviewer
Verification steps
The Custom query parameters option should be set to "namespace=ns1".