Adds Username field to AD authentication screen #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when user enters wrong username and password
fractalram
reviewed
May 28, 2019
| <td> | ||
| <input type="password" name="password" class="form-control" id="id_password" placeholder="AD Administrator password"> | ||
| <input type="text" name="username" class="form-control" id="user_name" placeholder="AD Server Username" value="{{form.username.value|default_if_none:''}}"> |
There was a problem hiding this comment.
id="id_username" placeholder="Enter AD Admnistrator's username"
| @@ -35,9 +35,16 @@ | |||
| <td> {{ form.realm.errors }} </td> | |||
| </tr> | |||
| <tr> | |||
| <td> <b>AD Admininstrator password </b><br> (Never stored. Used only to initially join AD realm) </td> | |||
| <th> AD Server Username: </th> | |||
There was a problem hiding this comment.
AD Administrator's username
| <td>{{ form.username.errors }}</td> | ||
| </tr> | ||
| <tr> | ||
| <td> <b>AD User password </b><br> (Never stored. Used only to initially join AD realm) </td> |
There was a problem hiding this comment.
AD administrator's password
| raise Exception("Invalid Credentials, Please try again") | ||
| elif "not found" in err: | ||
| raise Exception("Could not find an Active Directory user with the username: '%s'! " % cd["username"]) | ||
| elif cd["password"] in err: |
There was a problem hiding this comment.
Why do we have this condition?
There was a problem hiding this comment.
Because the original error message looked a bit cryptic and couple of users complained about the echo password | kinit statement in the error message. So we decided to add these exception messages.
fractalram
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AD authentication screen uses administrator user by default to bind to an AD server, these changes adds an Username field so that users have an option to use any privileged user to bind to the AD server. Exception messages have also been modified to inform user about incorrect username and password. (Addresses issue - #438)