Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow team slug instead of team id in github_team and github_team_members #1664

Merged
merged 5 commits into from
May 1, 2023
Merged

feat: allow team slug instead of team id in github_team and github_team_members #1664

merged 5 commits into from
May 1, 2023

Conversation

PabloPie
Copy link
Contributor

Resolves #1583

Behavior

Before the change?

  • github_team_members supports passing a slug instead of an id directly, but the schema for the resource doesn't because of the validation function
  • github_team doesn't support passing a slug instead of an id for the parent_team_id

After the change?

  • github_team_members no longer validates that the id is an int
  • github_team supports using a slug instead of an id for parent_team_id

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@PabloPie PabloPie changed the title Team id validation fix: allow team slug instead of team id in github_team and github_team_members Apr 24, 2023
@PabloPie PabloPie changed the title fix: allow team slug instead of team id in github_team and github_team_members feat: allow team slug instead of team id in github_team and github_team_members Apr 24, 2023
@kfcampbell kfcampbell added the Type: Bug Something isn't working as documented label May 1, 2023
kfcampbell
kfcampbell approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I'll get this released soon.

@kfcampbell kfcampbell merged commit c968888 into integrations:main May 1, 2023
@froblesmartin froblesmartin mentioned this pull request May 2, 2023
Closed
@dion-gionet dion-gionet mentioned this pull request May 2, 2023
Closed
1 task
@PabloPie PabloPie deleted the team-id-validation branch May 4, 2023 14:24
@kristian-lesko kristian-lesko mentioned this pull request Jun 22, 2023
Closed
@mikhailshilkov mikhailshilkov mentioned this pull request Sep 4, 2023
Closed
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@PabloPie @kfcampbell
feat: allow team slug instead of team id in github_team and github_te…
7dc6f8f 
…am_members (integrations#1664)

* fix: remove validation for team_id as it can also be a string

* feat: allow team slug for parent team id in team resource

* docs: add slug option to team resource

* feat: add test for gihub_team using slug for parent_team_id

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Validation error in github_team_membership when using team slug
2 participants
@PabloPie @kfcampbell