Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with variants like:
and noticed that many permutations of features will cause the test suite to fail in different ways.
This series annotates the tests (including the doctests) with the appropriate features to ensure that they should normally pass.
The one scenario where they don't pass is if none of the
ml-kem-512
,ml-kem-768
, orml-kem-1024
features are enabled. That is, these two ways of running still fail:I think that's probably OK. It would be nice if
Cargo.toml
could somehow be annotated explicitly that at least one of theml-kem-*
features must be enabled. I don't know how to do that, though.Note that the first commit in this series actually tunes up one of the documentation examples so that it doesn't rely on the
default-rng
feature, before annotating it for reliance onml-kem-512
. If you think it really should depend on bothml-kem-512
anddefault-rng
even though it uses a*_with_rng
function elsewhere, please go ahead and adjust it in that way.