Set FFI SONAME to fips203-ffi crate major version #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SONAME represents the backward-compatible API for a C shared object. Using the major version number for this seems like a reasonable first pass, given the semver semantics.
When doing an initial build against a library with an SONAME, the resulting ELF object stores the SONAME, not the literal filename that was found for linking. To make the test run correctly, we symlink the SONAME to the resultant object. This is a bit janky, for at least two reasons. - it would be better to have the shared object be named with the SONAME in the first place -- if we want to, then we can symlink to it without the SONAME. - if we have to find the SONAME in ffi/tests/Makefile, we should really be able to derive the SONAME from the info in ffi/Cargo.toml instead of hard-coding it in ffi/tests/Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONAME represents the backward-compatible API for a C shared object.
Using the major version number for this seems like a reasonable first pass, given the semver semantics.
Note that it would be better if Cargo handled this automatically itself: rust-lang/cargo#5045 But in the meantime, it isn't unreasonable to just drop it in explicitly.