Refine AbstractModule methods #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One idea is we can provide a common method for |
yangw1234
reviewed
Feb 5, 2018
| * | ||
| * This function will go over all the weights and gradWeights and make them view into a single | ||
| * tensor (one for weights and one for gradWeights). Since the storage of every weight and | ||
| * gradWeight is changed. |
There was a problem hiding this comment.
Feels like this sentence is not finished.
|
@zhichao-li This PR is removing the unnecessary zeroGrad methods. ZeroGrad is using parameter() method to get the grads. We needn't an extra getGrad methods |
yiheng
force-pushed
the
refine_get_parameters
branch
from
13e12ef
to
568a5d4
Compare
|
jenkins test pass |
yangw1234
reviewed
Feb 7, 2018
| Validator(this, dataSet).test(vMethods) | ||
| } | ||
|
|
||
| def quantize(): Module[T] = { | ||
| /** | ||
| * Quantize this module, whcih reduces the precison of the parameter. Get a higher speed with a |
There was a problem hiding this comment.
"which" and "precision" are spelled wrong.
|
LGTM |
yiheng
force-pushed
the
refine_get_parameters
branch
from
b6a123c
to
197f6cd
Compare
yiheng
force-pushed
the
refine_get_parameters
branch
from
19bba04
to
36f6cde
Compare
|
jenkins pass.merge |
psyyz10
pushed a commit
to psyyz10/BigDL
that referenced
this pull request
Mar 8, 2018
* make getParameter be final and private * remove updateParameter Method * remove useless override zeroGrad * fix comments * fix unit tests * fix unit tests * allocate gradWeight storage if it's not allocated * fix unit test * meet code review * make zeroGrad become final * fix compile error * add final to module apis * add private[bigdl] to some module methods * reorder the method sequence * meet code review * remove unnecessary getParameterTable and fix unit test * fix unit test * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is code refactor, include:
How was this patch tested?
unit test
Related links or issues (optional)
fixed #966