Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine AbstractModule methods #2262

Merged
merged 18 commits into from
Feb 9, 2018
Merged

Refine AbstractModule methods #2262

merged 18 commits into from
Feb 9, 2018

Commits on Feb 9, 2018

  1. make getParameter be final and private

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    6ffd06b View commit details
    Browse the repository at this point in the history

  2. remove updateParameter Method

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    028c17b View commit details
    Browse the repository at this point in the history

  3. remove useless override zeroGrad

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    9763e34 View commit details
    Browse the repository at this point in the history

  4. fix comments

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    565436a View commit details
    Browse the repository at this point in the history

  5. fix unit tests

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    cc467c5 View commit details
    Browse the repository at this point in the history

  6. fix unit tests

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    66345d4 View commit details
    Browse the repository at this point in the history

  7. allocate gradWeight storage if it's not allocated

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    149a982 View commit details
    Browse the repository at this point in the history

  8. fix unit test

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    ad0b41e View commit details
    Browse the repository at this point in the history

  9. meet code review

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    d6c8d4a View commit details
    Browse the repository at this point in the history

  10. make zeroGrad become final

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    4aab2d6 View commit details
    Browse the repository at this point in the history

  11. fix compile error

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    c59f32c View commit details
    Browse the repository at this point in the history

  12. add final to module apis

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    b172e77 View commit details
    Browse the repository at this point in the history

  13. add private[bigdl] to some module methods

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    d61fb44 View commit details
    Browse the repository at this point in the history

  14. reorder the method sequence

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    b01b4a1 View commit details
    Browse the repository at this point in the history

  15. meet code review

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    de631de View commit details
    Browse the repository at this point in the history

  16. remove unnecessary getParameterTable and fix unit test

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    36f6cde View commit details
    Browse the repository at this point in the history

  17. fix unit test

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    56c9559 View commit details
    Browse the repository at this point in the history

  18. fix unit test

    @yiheng
    yiheng committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    69810de View commit details
    Browse the repository at this point in the history