Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized pointer in IntelDeflater.cc #89

Closed
mirounga opened this issue Feb 16, 2018 · 4 comments
Closed

Uninitialized pointer in IntelDeflater.cc #89

mirounga opened this issue Feb 16, 2018 · 4 comments
Assignees

Comments

@mirounga
Copy link

Memory at uninitialized pointer is being written to here

@gspowley
Copy link
Contributor

@pnvaidya can you please take a look at this?

@rpomaris
Copy link

We're working on a new release - will check this and confirm it's resolved with latest version of GKL.

Kmannth added a commit to Kmannth/GKL that referenced this issue Aug 26, 2020
Add an alloction and free block struct in question.

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>
@Kmannth
Copy link
Contributor

Kmannth commented Aug 26, 2020

#114 has an inital fix for this issue.

@Kmannth
Copy link
Contributor

Kmannth commented Aug 26, 2020

The patch has been landed to Master please retest and let us know if you still see the issue.

@Kmannth Kmannth closed this as completed Aug 26, 2020
SnehalA added a commit to SnehalA/GKL that referenced this issue Sep 23, 2020
* update gatk-native-bindings dependency to 1.0.0

* This is a cosmetic change, 0.1.0-rc-1 was r-released as 1.0.0 once we verified it was ok.  It looks less weird to use the release version though.

* Smithwatermen Memory allocation defensive code

    Add denfensive code where Memory Alloctions are involved.
    This will reduce crashes that happen when memory allocations
    fail in SmithWaterman.

    Move to _mm_free for memory allocated wtih _mm_malloc.

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>

* Fix for "Uninitialized pointer in IntelDeflater.cc Intel-HLS#89"

Add an alloction and free block struct in question.

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>

Co-authored-by: Louis Bergelson <louisb@broadinstitute.org>
Co-authored-by: kmannthe <keith.mannthey@intel.com>
Co-authored-by: Kmannth <32776479+Kmannth@users.noreply.github.com>
Kmannth added a commit that referenced this issue Sep 29, 2020
* update for python utility

* Merge (#7)

* update gatk-native-bindings dependency to 1.0.0

* This is a cosmetic change, 0.1.0-rc-1 was r-released as 1.0.0 once we verified it was ok.  It looks less weird to use the release version though.

* Smithwatermen Memory allocation defensive code

    Add denfensive code where Memory Alloctions are involved.
    This will reduce crashes that happen when memory allocations
    fail in SmithWaterman.

    Move to _mm_free for memory allocated wtih _mm_malloc.

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>

* Fix for "Uninitialized pointer in IntelDeflater.cc #89"

Add an alloction and free block struct in question.

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>

Co-authored-by: Louis Bergelson <louisb@broadinstitute.org>
Co-authored-by: kmannthe <keith.mannthey@intel.com>
Co-authored-by: Kmannth <32776479+Kmannth@users.noreply.github.com>

* minor change

* pyutil update

* remove extra space

Co-authored-by: Louis Bergelson <louisb@broadinstitute.org>
Co-authored-by: kmannthe <keith.mannthey@intel.com>
Co-authored-by: Kmannth <32776479+Kmannth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants