This repository has been archived by the owner on Apr 16, 2019. It is now read-only.
Fixes issue #838. This patch makes it possible to use loadDiv both with ... #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th with pushState routers and with internal AF router. loadDiv will now only remove parameters (delimited in AF by a slash) only when those parameters come after a hash character.
imaffett
pushed a commit
that referenced
this pull request
Mar 26, 2015
Fixes issue #838. This patch makes it possible to use loadDiv both with ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it possible to use loadDiv both with pushState routers and with internal AF router fixing issue #838.
loadDiv will now remove parameters (delimited in AF by a slash) only when those parameters come after a hash character. This way it is still possible to keep current AF functionality but still make it possible to be used with pushStateRouters simply calling loadDiv("path/subpath", ...)
For example: app.com/#panelid/option1/option2 will become -> app.com/#panelid
But: app.com/path/path2/path3 will still be -> app.com/path/path2/path3
I tested kitchen sink and loadDiv still correctly wipes the "/foo/bar/something" part when loading appframework-master/#afuidemo/foo/bar/something