Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new IOCTL call to set max ring size #261

Closed
wants to merge 1 commit into from
Closed

Add new IOCTL call to set max ring size #261

wants to merge 1 commit into from

Conversation

KamilKoprykIntel
Copy link
Contributor

Signed-off-by: Kamil Kopryk kamil.kopryk@intel.com

@KamilKoprykIntel
Add new IOCTL call to set max ring size
c65d22d 
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
@MichalMrozek
Copy link
Contributor

looks good to me

fengguang pushed a commit to 0day-ci/linux that referenced this pull request Feb 22, 2020
@ickle @intel-lab-lkp
drm/i915: Allow userspace to specify ringsize on construction
44561a1 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this pull request Feb 24, 2020
@ickle @intel-lab-lkp
drm/i915: Allow userspace to specify ringsize on construction
ac91093 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this pull request Feb 25, 2020
@ickle @intel-lab-lkp
drm/i915: Allow userspace to specify ringsize on construction
c6369a7 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this pull request Feb 25, 2020
@ickle
drm/i915: Allow userspace to specify ringsize on construction
88be76c 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
hohoxu pushed a commit to hohoxu/n5kernel that referenced this pull request Feb 28, 2020
@ickle @hohoxu
drm/i915: Allow userspace to specify ringsize on construction
34632ba 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
@gfxstrand
Copy link

gfxstrand commented Mar 19, 2021 •
edited

What is the purpose of this? I assume it's because you're having problems with overrunning the ring. I'm working on trying to clean up old, unused, kernel APIs and have proposed removing this:

https://lists.freedesktop.org/archives/intel-gfx/2021-March/262558.html

I have a few reasons for suggesting its removal:

  1. It doesn't seem that important. If it were, this PR wouldn't have sat for a year.
  2. The ring size doesn't seem like something userspace should be setting. If the ring is constantly getting over-filled, i915 should detect that somehow and grow it.
  3. This API makes no sense once we enable GuC scheduling; it's an implementation detail of the execlist scheduler.

If this is really causing perf issues, we can just bump the default. A context is already 80K or so; a few extra K worth of ring buffer won't hurt anyone.

If you really think this is important and the right way to solve the problem, then please speak up and provide some justification. Unfortunately, if there is good justification for this, no one bothered to put it in this PR.

@KamilKoprykIntel
Copy link
Contributor Author

Hi @jekstrand
I'll contact you by email.
I'm closing this PR for now.

neelchauhan pushed a commit to neelchauhan/drm-kmod that referenced this pull request Oct 25, 2021
@ickle @neelchauhan
drm/i915: Allow userspace to specify ringsize on construction
045c578 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
neelchauhan pushed a commit to neelchauhan/drm-kmod that referenced this pull request Nov 1, 2021
@ickle @neelchauhan
drm/i915: Allow userspace to specify ringsize on construction
39ab6b7 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 9, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
4f2392e 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 12, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
8028bfd 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 14, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
7946c8a 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 15, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
3bd4b7a 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 18, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
d16648b 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 20, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
71f5d99 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 23, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
08c183e 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 24, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
cd660ec 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Nov 30, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
ccebc70 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to wulf7/drm-kmod that referenced this pull request Dec 4, 2021
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
8821ce2 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
wulf7 pushed a commit to freebsd/drm-kmod that referenced this pull request Jan 11, 2022
@ickle @wulf7
drm/i915: Allow userspace to specify ringsize on construction
596749d 
No good reason why we must always use a static ringsize, so let
userspace select one during construction.

Link: intel/compute-runtime#261
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Steve Carbonari <steven.carbonari@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225192206.1107336-2-chris@chris-wilson.co.uk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalMrozek MichalMrozek Awaiting requested review from MichalMrozek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilKoprykIntel @MichalMrozek @gfxstrand