Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use VM when ppGTT is invalid/unassigned #361

Closed
wants to merge 1 commit into from
Closed

Don't use VM when ppGTT is invalid/unassigned #361

wants to merge 1 commit into from

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Sep 20, 2020

VM wasn't ported on FreeBSD but "create" ioctl succeeds, confusing NEO whether VM can be used.

freebsd/drm-kmod#24

Copy link
Contributor

@MichalMrozek MichalMrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add Unit Level Tests?

@HoppeMateusz
Copy link
Contributor

Please fix commit message following the rules:
https://github.com/intel/compute-runtime/blob/master/CONTRIBUTING.md#2-certificate-of-origin

You will have to add empty line after commit message, and Signed-off-by:

@jbeich
Copy link
Contributor Author

jbeich commented Oct 26, 2021

can you add Unit Level Tests?

2 years ago when porting NEO I've spent ~2 additional days (2x more than IGC + NEO without tests) trying to unbreak build of unit tests but eventually gave up by adding SKIP_ALL_ULT (SKIP_UNIT_TESTS nowadays) and removing related patches to ease the maintenance. IIRC, there were many dependencies not just on Linux features but GNU libc specifics which made me wonder if the tests supported musl or bionic.

Signed-off-by: Jan Beich <jbeich@FreeBSD.org>
@jbeich
Copy link
Contributor Author

jbeich commented Oct 26, 2021

You will have to add empty line after commit message, and Signed-off-by:

Done.

@HoppeMateusz
Copy link
Contributor

You will have to add empty line after commit message, and Signed-off-by:

Done.

Thanks for the update, commit message has been verified.

@zzdanowicz
Copy link
Contributor

GNU libc specifics which made me wonder if the tests supported musl or bionic.

Can you tell what were the problem with glibc? FreeBSD does not have it, so its equivalent of libc might be different - asking out of curiosity?

@HoppeMateusz
Copy link
Contributor

We usually require unit tests for every change, but in this case, due to small change size and justified problems, we decided to waive this requirement and will merge the PR.

Thanks for contribution

@HoppeMateusz
Copy link
Contributor

merged as bb6ed00

@jbeich
Copy link
Contributor Author

jbeich commented Nov 5, 2021

Confirmed downstream.

@jbeich jbeich closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants