-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use VM when ppGTT is invalid/unassigned #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add Unit Level Tests?
Please fix commit message following the rules: You will have to add empty line after commit message, and Signed-off-by: |
2 years ago when porting NEO I've spent ~2 additional days (2x more than IGC + NEO without tests) trying to unbreak build of unit tests but eventually gave up by adding |
Signed-off-by: Jan Beich <jbeich@FreeBSD.org>
Done. |
Thanks for the update, commit message has been verified. |
Can you tell what were the problem with glibc? FreeBSD does not have it, so its equivalent of libc might be different - asking out of curiosity? |
We usually require unit tests for every change, but in this case, due to small change size and justified problems, we decided to waive this requirement and will merge the PR. Thanks for contribution |
merged as bb6ed00 |
VM wasn't ported on FreeBSD but "create" ioctl succeeds, confusing NEO whether VM can be used.
freebsd/drm-kmod#24