-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/cri: remove support for the obsolete v1alpha2 CRI protocol. #1081
Conversation
3712af4
to
ca1d9e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ca1d9e3
to
801ac79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
=======================================
Coverage 32.12% 32.12%
=======================================
Files 64 64
Lines 9937 9937
=======================================
Hits 3192 3192
Misses 6449 6449
Partials 296 296 ☔ View full report in Codecov by Sentry. |
801ac79
to
132bb2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I suppose this is something to be emphasized in release notes... CRI-RM 0.9 requires Kubernetes 1.23+ and containerd 1.6+ or something. Which is fine as earlier versions are already EOL.
LGTM |
Yes, definitely. @klihub please rebase and let's see how it goes. I think this would be "Ready for review" 😊 |
132bb2d
to
3865cac
Compare
Or should we wait for #1079? |
Fair point |
Ditch support (and protocol conversion) for the obsolete v1alpha2 version of the CRI protocol. Implement the missing v1 RuntimeService client and server interfaces. Implement relaying for these same interfaces with the exception of the GetContainerEvents/PLEG interface Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
3865cac
to
3ffff03
Compare
Don't force static-pools e2e test distro to debian/sid. It looks like govm fails to boot it on recent fedora/docker combos. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Okay, with the latest commit at the tip, all tests pass. |
Yeah, same here. LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @klihub!
This patch set
Note that relaying for the streaming PLEG/GetContainerEvents interface is not implemented.