Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Checker Request: opensuse libsolv #1491

Closed
terriko opened this issue Dec 28, 2021 · 3 comments · Fixed by #1562
Closed

New Checker Request: opensuse libsolv #1491

terriko opened this issue Dec 28, 2021 · 3 comments · Fixed by #1562
Labels
signature needs work The signature used in this checker has problems and needs reworking

Comments

@terriko
Copy link
Contributor

terriko commented Dec 28, 2021

Note: I'm adding some new checker requests based on lib* packages on CentOS that have known vulnerabilities. None of these are urgent requests, they're meant to just add some new beginner-friendly stuff to the queue. If it turns out to be hard to do, please comment here so we can remove the "good first issue" tag!

New checker request: opensuse libsolv

Website: ??

CVEs: https://www.cvedetails.com/vulnerability-list/vendor_id-8184/product_id-51703/Opensuse-Libsolv.html

Instructions: How to add a new checker to the CVE Binary Tool

This may also be a great opportunity to try out the checker creation helper script created by @peb-peb.

@terriko terriko added the good first issue Good for newcomers label Dec 28, 2021
@deepakdinesh1123
Copy link

Can I work on this?

@deepakdinesh1123
Copy link

@terriko Should the checker for libsolv-tools also be added ? I ran the helper script against libsolv-0.6.34-lp150.1.2.src.rpm but except for the vendor product all the other patterns came up empty. I tried to build the library myself and ran the strings and find commands against the binaries but I could not obtain the version patterns or the contains patterns could you please tell me on how to properly build the library myself and obtain the patterns?

@terriko
Copy link
Contributor Author

terriko commented Jan 25, 2022

Go ahead and try libsolv-tools if it works!

It's entirely possible that libsolv itself doesn't have good pattern strings (or more accurately, doesn't have ones that work with our methodology). Sometimes checkers are hard to build and you're not doing anything wrong! Since that seems to be the case here, I'm going to go ahead and remove the "good first issue" flag and instead add a "signature needs work" flag to indicate that writing this checker may require some creative thinking.

Since you're a new contributor here, I'd recommend you try another easy issue instead and leave this one for another time (or for someone else who's looking for a challenge!).

@terriko terriko added signature needs work The signature used in this checker has problems and needs reworking and removed good first issue Good for newcomers labels Jan 25, 2022
terriko pushed a commit that referenced this issue Mar 3, 2022
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
terriko pushed a commit to terriko/cve-bin-tool that referenced this issue Mar 9, 2022
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
signature needs work The signature used in this checker has problems and needs reworking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants