Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checker): libsolv checker #1562

Merged
merged 5 commits into from Mar 3, 2022
Merged

feat(checker): libsolv checker #1562

merged 5 commits into from Mar 3, 2022

Conversation

rhythmrx9
Copy link
Contributor

closes #1491

@anthonyharrison
Copy link
Contributor

Welcome @rhythmrx9. Can you ensure your pull request conforms to the conventional commits format.

@rhythmrx9 @BreadGenie
refactor: version_patterns for libsolv.py
b3b1092 
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
@rhythmrx9 rhythmrx9 changed the title New checker: libsolv feat(checker): libsolv checker Jan 30, 2022
@rhythmrx9
Copy link
Contributor Author

Thanks @anthonyharrison .
Changed PR title, will do the same for previous PR as well.

terriko
terriko requested changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled CI. Looks like you're failing the spelling check because of the new checker name going into the docs, so you'll need to add that.

@rhythmrx9
Copy link
Contributor Author

Thanks, added.

terriko
terriko requested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also has a conflict because of the checker table. (see #1582)

Since we don't have a resolution for that, maybe just update this one after your other one gets merged?

terriko
terriko approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for persevering on all these checkers! This is still failing a CI check for the commit message (which will resolve when I squash the commits) and has a disk I/O error that seems unrelated to this code, so I'm going to go ahead and merge it now.

@terriko terriko merged commit 70973dd into intel:main Mar 3, 2022
@rhythmrx9 rhythmrx9 deleted the libsolv branch March 7, 2022 14:36
terriko pushed a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
@rhythmrx9 @BreadGenie @terriko
feat(checker): libsolv checker (closes intel#1491) (intel#1562)
e2d5ab7 
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BreadGenie BreadGenie BreadGenie left review comments

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Checker Request: opensuse libsolv
4 participants
@rhythmrx9 @anthonyharrison @terriko @BreadGenie