fix: fix symlink handling #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix symlink handling added by commit f13f559: if one of the file is a link, filenames list will be updated resulting in the loop ending before all links are removed. To avoid this issue, loop on a copy of filenames. Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 75.41% 80.51% +5.09%
==========================================
Files 808 822 +14
Lines 11983 12699 +716
Branches 1598 1978 +380
==========================================
+ Hits 9037 10224 +1187
+ Misses 2593 2053 -540
- Partials 353 422 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix symlink handling added by commit f13f559: if one of the file is a link, filenames list will be updated resulting in the loop ending before all links are removed. To avoid this issue, loop on a copy of filenames.