Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set packaging minimum version #4367

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

ffontaine
Copy link
Contributor

Set packaging minimum version to 22.0 to avoid the following error with setuptools 71.x:

TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'

Likelihood of encountering this error increased since commit e4239bd which bumped minimum version of setuptools from 65.5.1 to 70.0.0

More information:

Set packaging minimum version to 22.0 to avoid the following error with
setuptools 71.x:

TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'

Likelihood of encountering this error increased since commit
e4239bd which bumped minimum version of
setuptools from 65.5.1 to 70.0.0

More information:
 - pypa/setuptools#4483
 - pypa/setuptools#4501

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm kind of surprised we didn't have a min version already from snyk.

@terriko terriko merged commit 978a5bd into intel:main Aug 20, 2024
21 checks passed
@ffontaine ffontaine deleted the update-packaging branch August 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants