Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: Rename directory property to location #662

Closed
pdxjohnny opened this issue May 20, 2020 · 11 comments · Fixed by #1128, #1172 or #1199
Closed

model: Rename directory property to location #662

pdxjohnny opened this issue May 20, 2020 · 11 comments · Fixed by #1128, #1172 or #1199
Labels
enhancement New feature or request gsoc Google Summer of Code related kind/ml Issues partaining to machine learning p2 Medium Priority tL Esitmated Time To Complete: Long

Comments

@pdxjohnny
Copy link
Member

pdxjohnny commented May 20, 2020

Support Archive Storage for Models

The goal of this project is the modify Models and DataFlows to support saving
and loading from archives (such as .zip and .tar for example).

Currently all DFFML models have a directory property, which is where they
store the contents of the model's state. It does not currently hold a copy of
the model's config.

We'll want to modify the Model's context entry and exit code to have it
pack/unpack it's config and its saved state directory from/into the archive at
location.

Skills

  • Python

Difficulty

Beginner/Intermediate

Related Readings

Getting Started

Potential Mentors

Tracking and Discussion

This project is related to the following issues. Please discuss and ask
questions in the issue comments. Please also ping mentors on
Gitter when you post on the following
issues so that they are sure to see that you've commented.

@pdxjohnny pdxjohnny added enhancement New feature or request kind/ml Issues partaining to machine learning p2 Medium Priority tL Esitmated Time To Complete: Long labels May 20, 2020
@pdxjohnny pdxjohnny added this to the 0.5.0 Beta Release milestone May 20, 2020
@sudharsana-kjl
Copy link
Contributor

@pdxjohnny I'd like to work on this issue

@pdxjohnny
Copy link
Member Author

@sudharsana-kjl Sweet! I forgot to say sorry, we need to do #655 first

@pdxjohnny
Copy link
Member Author

This could be done now, but that issue and this issue will probably change a lot of the same code, so it's probably best if we do that issue first because it needs to get done before the next release

@pdxjohnny
Copy link
Member Author

And if we do both at the same time then we'll end up with a nasty merge

@sudharsana-kjl
Copy link
Contributor

sudharsana-kjl commented May 24, 2020

@pdxjohnny I'll work on #655 first and then come back to this!

@up1512001
Copy link

up1512001 commented Mar 25, 2021

@pdxjohnny
I want to do this from gsoc. an intermediate level knowledge of python can do this ?

@elaineqing
Copy link

Hi, just wondering if this is still open for gsoc 2021? Thank you

@programmer290399
Copy link
Contributor

programmer290399 commented Jul 9, 2021

Related Comment from PR#1128

On load / save, look at the extension of the location property. Create two DataFlow objects where the operations in them are dependent the extension. One dataflow for loading from the location, one for saving back to the location.

@programmer290399
Copy link
Contributor

programmer290399 commented Jul 15, 2021

Related discussion from Weekly Sync 2021-07-13
Related discussion from Weekly Sync 2021-07-27

pdxjohnny pushed a commit that referenced this issue Jul 24, 2021
high_level.py becomes high_level/{ml,dataflow,source}.py

Fixes: #1170
Related: #662
@pdxjohnny pdxjohnny reopened this Jul 27, 2021
pdxjohnny pushed a commit that referenced this issue Aug 24, 2021
Pulled __aenter__/__aexit__() out of context classes put in parent
classes.

Added a tutorial for archive support.

Spacy model_name_or_path was changed to model_name.

Fixes: #662

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny pushed a commit to pdxjohnny/dffml that referenced this issue Mar 11, 2022
high_level.py becomes high_level/{ml,dataflow,source}.py

Fixes: intel#1170
Related: intel#662
pdxjohnny pushed a commit to pdxjohnny/dffml that referenced this issue Mar 11, 2022
Pulled __aenter__/__aexit__() out of context classes put in parent
classes.

Added a tutorial for archive support.

Spacy model_name_or_path was changed to model_name.

Fixes: intel#662

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny pushed a commit that referenced this issue Mar 12, 2022
high_level.py becomes high_level/{ml,dataflow,source}.py

Fixes: #1170
Related: #662
pdxjohnny pushed a commit that referenced this issue Mar 12, 2022
Pulled __aenter__/__aexit__() out of context classes put in parent
classes.

Added a tutorial for archive support.

Spacy model_name_or_path was changed to model_name.

Fixes: #662

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
@ren276
Copy link

ren276 commented Apr 12, 2022

Hi ! Decided to work on this issue so anyone for a headstart ?

@programmer290399
Copy link
Contributor

Hey @ren276 !!
This issue has been closed and is already implemented.
Please pick any other open issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gsoc Google Summer of Code related kind/ml Issues partaining to machine learning p2 Medium Priority tL Esitmated Time To Complete: Long
Projects
None yet
6 participants