Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model : Add Support for Archive Storage of Models #1174

Closed
wants to merge 51 commits into from
Closed

model : Add Support for Archive Storage of Models #1174

wants to merge 51 commits into from

Conversation

programmer290399
Copy link
Collaborator

@programmer290399 programmer290399 commented Jul 27, 2021

  • Fixes: model: Rename directory property to location #662
  • Have updated all the models, this branch is ready for final review and merge.
  • No tests are failing except commit lint and I have updated the enhancement issue as it shouldn't.
  • TODO:
    • Add Tutorial on Archive Support
    • Add tests for newly added dffml.df.archive
    • Update SLR model
    • Update Scikit model
    • Update Scratch model
    • Update Daal4py model
    • Update Xgboost model
    • Update Auto Sklearn model
    • Update Spacy model
    • Update Vowpal Wabbit model
    • Update Pytorch model
    • Update Tensorflow model
    • Update Tensorflow hub model
    • Remove any debugging related code

dffml/model/model.py Outdated Show resolved Hide resolved
@programmer290399
Copy link
Collaborator Author

programmer290399 commented Aug 5, 2021

Blank Diagram (1)
@pdxjohnny @sakshamarora1 please provide your inputs.

dffml/model/model.py Outdated Show resolved Hide resolved
dffml/model/model.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #1174 (0337d79) into master (413bf3e) will decrease coverage by 0.21%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
- Coverage   85.43%   85.22%   -0.22%     
==========================================
  Files         170      171       +1     
  Lines       10718    10883     +165     
  Branches     1759     1788      +29     
==========================================
+ Hits         9157     9275     +118     
- Misses       1214     1252      +38     
- Partials      347      356       +9     
Impacted Files Coverage Δ
tests/docs/test_consoletest.py 59.49% <ø> (ø)
dffml/model/model.py 65.69% <38.98%> (-15.14%) ⬇️
dffml/df/archive.py 93.93% <93.93%> (ø)
tests/test_df.py 100.00% <100.00%> (ø)
dffml/util/data.py 72.92% <0.00%> (-2.77%) ⬇️
tests/util/test_net.py 98.36% <0.00%> (-1.64%) ⬇️
dffml/noasync.py 78.94% <0.00%> (-1.06%) ⬇️
dffml/base.py 83.81% <0.00%> (-0.29%) ⬇️
dffml/util/testing/consoletest/commands.py 61.31% <0.00%> (-0.09%) ⬇️
dffml/source/df.py 75.60% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413bf3e...0337d79. Read the comment docs.

@pdxjohnny
Copy link
Member

Where is this at right now? We're closing on GSoC deadline and want to make sure this gets completed

@programmer290399 programmer290399 changed the title WIP: model : Add Support for Archive Storage of Models model : Add Support for Archive Storage of Models Aug 21, 2021
@pdxjohnny
Copy link
Member

Merged as 38390a4

@pdxjohnny pdxjohnny closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model: Rename directory property to location
3 participants