Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: usage: Add example usage for new image operations #777

Merged
merged 17 commits into from
Aug 26, 2020

Conversation

sakshamarora1
Copy link
Contributor

No description provided.

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Copy link
Member

@pdxjohnny pdxjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ touch examples/flower17/__init__.py

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
docs/usage/flower17.rst Outdated Show resolved Hide resolved
docs/usage/flower17.rst Outdated Show resolved Hide resolved
docs/usage/flower17.rst Outdated Show resolved Hide resolved
docs/usage/flower17.rst Outdated Show resolved Hide resolved
Copy link
Member

@pdxjohnny pdxjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

examples: flower17: Use shutil to copy files into train and test directories

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>

All the images are now in a folder called `jpg`.
Let's split these images into flower_dataset/train and flower_dataset/test directories,
each directory containing sub-directories corresponding to the 17 flower classes using split.py.
Copy link
Member

@pdxjohnny pdxjohnny Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
each directory containing sub-directories corresponding to the 17 flower classes using split.py.
each directory containing sub-directories corresponding to the 17 flower classes using
**split.py**. This splitting code is documented `here <link to where they tell you to do it this way>`_

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I wrote the splitting code myself, it's not documented anywhere.

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Copy link
Member

@pdxjohnny pdxjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure the user has everything installed if they skip the first tutorial

docs/usage/flower17/flower17_pytorch.rst Outdated Show resolved Hide resolved
@pdxjohnny
Copy link
Member

@sakshamarora1 Can you update the CHANGELOG please. Then I'll merge. Awesome work on this!!!

@sakshamarora1
Copy link
Contributor Author

sakshamarora1 commented Aug 26, 2020

@pdxjohnny Thankyou! Also, with the changes in the new PR, I'd have to update pytorch example to have the new config options. Should I merge master there after this is merged and update new changes in #839 ?

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #777 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   87.25%   87.37%   +0.12%     
==========================================
  Files         132      132              
  Lines        8016     8019       +3     
  Branches     1298     1298              
==========================================
+ Hits         6994     7007      +13     
+ Misses        772      765       -7     
+ Partials      250      247       -3     
Impacted Files Coverage Δ
dffml/noasync.py 79.31% <0.00%> (+1.12%) ⬆️
tests/util/test_net.py 100.00% <0.00%> (+1.81%) ⬆️
dffml/util/data.py 77.84% <0.00%> (+2.84%) ⬆️
dffml/plugins.py 84.21% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cffbe66...3a79a52. Read the comment docs.

@pdxjohnny
Copy link
Member

@pdxjohnny Thankyou! Also, with the changes in the new PR, I'd have to update pytorch example to have the new config options. Should I merge master there after this is merged and update new changes in #839 ?

@sakshamarora1 Yes, that's a good plan

@pdxjohnny pdxjohnny merged commit f757836 into intel:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants