Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: pytorch: Add custom Neural Network & layer support and loss function entrypoints #839

Merged
merged 28 commits into from
Sep 1, 2020

Conversation

sakshamarora1
Copy link
Contributor

@sakshamarora1 sakshamarora1 commented Aug 23, 2020

Fixes: #794

TODOs:

  • Merge master after util: cli: arg: Add configloading ability to parse_unknown #838 gets merged
  • Add tests for all new changes
  • Add documentation and example
  • Add last layer addition support in model/pytorch/dffml_model_pytorch/pytorch_pretrained.py
  • Update flower classification example after merging master
  • Make changes in model.pytorch/dffml_model_pytorch/pytorch_base.py to support non classification/image processing tasks
  • Add entrypoint support for optimizers and learning rate schedulers in pytorch after their annotations are added in the PyTorch source code (probably in their next release as they are working on it right now)

The last 2 points in the list will be their own separate pull requests

I also want to try and find if there's a non-confusing way to connect pre-trained model architectures and custom neural nets after all of the above has been done!

Signed-off-by: sakshamarora1 sakshamarora1001@gmail.com

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@sakshamarora1 sakshamarora1 changed the title model: pytorch: Add custom Neural Network support and loss function entrypoints model: pytorch: Add custom Neural Network & layer support and loss function entrypoints Aug 24, 2020
Copy link
Member

@pdxjohnny pdxjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure we have both CLI and python example usage that will show up on docs site.

sakshamarora1 and others added 12 commits August 26, 2020 22:43
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Due to codeql's lack of understanding of metaclasses

Related: github/codeql#2445

Signed-off-by: John Andersen <john.s.andersen@intel.com>
Signed-off-by: John Andersen <john.s.andersen@intel.com>
Add a function to run a doctest of an object and raise an excpetion if
it failed.

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
…te_layer

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         132      132           
  Lines        8044     8044           
  Branches     1303     1303           
=======================================
  Hits         7022     7022           
  Misses        773      773           
  Partials      249      249           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5caed54...5969e40. Read the comment docs.

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
…tils

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
…ample

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@sakshamarora1
Copy link
Contributor Author

@pdxjohnny Should this example be under tutorials instead of usage?

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@pdxjohnny pdxjohnny merged commit 322c49f into intel:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model: pytorch: Allow users to define layers in neural network
3 participants