Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: pytorch: Add PyTorch based pre-trained ConvNet models #784

Merged
merged 12 commits into from
Jul 30, 2020

Conversation

sakshamarora1
Copy link
Contributor

@sakshamarora1 sakshamarora1 commented Jul 17, 2020

Closes: #765

Signed-off-by: sakshamarora1 sakshamarora1001@gmail.com

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request introduces 3 alerts when merging ffe195a into b7e9d30 - view on LGTM.com

new alerts:

  • 3 for Unused import

@codecov-commenter
Copy link

Codecov Report

Merging #784 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         130      130           
  Lines        7897     7897           
  Branches     1269     1269           
=======================================
  Hits         6906     6906           
  Misses        752      752           
  Partials      239      239           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e9d30...ffe195a. Read the comment docs.

Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Copy link
Member

@pdxjohnny pdxjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is similar to model/scikit let's copy what was done in the __init__.py into model/pytorch/dffml_model_pytorch/__init__.py and modify accordingly

model/pytorch/tests/test_resnet18.py Outdated Show resolved Hide resolved
model/pytorch/tests/test_resnet18.py Outdated Show resolved Hide resolved
else self._model.fc.parameters()
)

self.criterion = nn.CrossEntropyLoss()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll follow #806 guide once it's complete to make these customizable

model/pytorch/dffml_model_pytorch/pytorch_base.py Outdated Show resolved Hide resolved
model/pytorch/dffml_model_pytorch/pytorch_base.py Outdated Show resolved Hide resolved
model/pytorch/dffml_model_pytorch/pytorch_base.py Outdated Show resolved Hide resolved
model/pytorch/dffml_model_pytorch/pytorch_base.py Outdated Show resolved Hide resolved
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2020

This pull request introduces 1 alert when merging a2a2872 into 6a26289 - view on LGTM.com

new alerts:

  • 1 for Unused import

model/pytorch/LICENSE Outdated Show resolved Hide resolved
Signed-off-by: sakshamarora1 <sakshamarora1001@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2020

This pull request introduces 1 alert when merging e8acc4f into 6a26289 - view on LGTM.com

new alerts:

  • 1 for Unused import

@pdxjohnny pdxjohnny merged commit 4e7b7e8 into intel:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model: pytorch: New model for images
3 participants