This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Port to gupnp-1.2 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of gupnp breaks backwards compatibility. Fortunately, there are not many calls to gupnp functions in core, so we just needed to bump the dependencies. There is one deprecated gupnp_service_proxy_cancel_action call but I am not sure how to change it without breaking Dleyna API. Let's leave it for now.
8 tasks
|
LGTM. Not sure if anyone from Intel is taking care of this project still? |
Closed
|
I think this might need an ABI bump |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of gupnp breaks backwards compatibility. Fortunately, there are not many calls to gupnp functions in core, so we just needed to bump the dependencies.
There is one deprecated gupnp_service_proxy_cancel_action call but I am not sure how to change it without breaking Dleyna API. Let's leave it for now.