Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gupnp: 1.0.3 → 1.2.0 #57736

Merged
merged 11 commits into from
Apr 17, 2019
Merged

gupnp: 1.0.3 → 1.2.0 #57736

merged 11 commits into from
Apr 17, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 16, 2019

Motivation for this change

Semi-independent part of #57027

gupnp-1.2 is incompatible with 1.0 branch, we need to patch the following packages:

  • gupnp-igd MR
  • dleyna-core PR
  • grilo-plugins did not use gupnp for a long time
  • gupnp-tools commit
  • dleyna-renderer arch patch even though the hack looks horrible
  • dleyna-server PR
  • mate.caja-extensions builds fine without it; @romildo

Things depending just on gupnp-igd do not need updated as its API did not change.

Other to-dos

cc @hedning @worldofpeace

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 16, 2019
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Mar 16, 2019
@jtojnar jtojnar marked this pull request as ready for review March 16, 2019 05:27
@worldofpeace
Copy link
Contributor

gupnp-igd tests are stalling

From what you linked it looks like we need a way within the build to let our non-root process bind to a privileged port/s?

@jtojnar
Copy link
Member Author

jtojnar commented Mar 18, 2019

Or maybe patch the ports if possible.

@worldofpeace
Copy link
Contributor

Wait, are gupnp-igd tests stalling on master as well?

@jtojnar
Copy link
Member Author

jtojnar commented Mar 22, 2019

Should not be, this was a regression fixed by the patches listed above.

@worldofpeace
Copy link
Contributor

Should not be, this was a regression fixed by the patches listed above.

Looks like something else is up https://hydra.nixos.org/build/90915967 😕

@hedning
Copy link
Contributor

hedning commented Mar 22, 2019

Pretty sure that's a transient error, I've seen quite a few builds which hydra says failed, the log seems fine and it's possible to fetch the output from the cache.

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@jtojnar
Copy link
Member Author

jtojnar commented Apr 16, 2019

Updated gupnp-tools, making gupnp-igd the last project without a new release. It probably does not make sense to wait for it.

@jtojnar jtojnar merged commit 6ae33c9 into NixOS:master Apr 17, 2019
@jtojnar jtojnar deleted the gupnp-1.2 branch April 17, 2019 09:07
@worldofpeace
Copy link
Contributor

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants