-
Notifications
You must be signed in to change notification settings - Fork 51
Fix _plaintext is too small, and fix dependency in Makefile #267
Conversation
I think Related to stack oob in issue #265 |
core/Makefile
Outdated
@@ -207,7 +207,7 @@ Enclave/enclave_hsm_t.o: Enclave/enclave_hsm_t.c | |||
@$(CXX) $(Enclave_C_Flags) -c $< -o $@ | |||
@echo "CXX <= $<" | |||
|
|||
Enclave/%.o: Enclave/%.cpp | |||
Enclave/%.o: Enclave/%.cpp Enclave/enclave_hsm_t.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.c or .h ?
Oh, sorry, I update it currently, please see newest commit I find above BUGs via fuzzing and sanitizer, thus may not so familiar with code context |
core/Makefile
Outdated
@@ -203,11 +203,13 @@ Enclave/enclave_hsm_t.c: $(SGX_EDGER8R) Enclave/enclave_hsm.edl | |||
@cd Enclave && $(SGX_EDGER8R) --trusted ../Enclave/enclave_hsm.edl --search-path ../Enclave --search-path ../Enclave/self_test --search-path $(SGX_SDK)/include --search-path $(OPENSSL_PATH)/include | |||
@echo "GEN => $@" | |||
|
|||
Enclave/enclave_hsm_t.h: Enclave/enclave_hsm_t.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Our existing codes are not standard. Could we change Line 202 to:
Enclave/enclave_hsm_t.h : .....
And update your line to:
Enclave/enclave_hsm_t.c: Enclave/enclave_hsm_t.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated commit
No description provided.