This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Fix _plaintext is too small, and fix dependency in Makefile #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think Related to stack oob in issue #265 |
yang8621
reviewed
Jun 7, 2023
yang8621
reviewed
Jun 7, 2023
core/Makefile
Outdated
| @@ -207,7 +207,7 @@ Enclave/enclave_hsm_t.o: Enclave/enclave_hsm_t.c | |||
| @$(CXX) $(Enclave_C_Flags) -c $< -o $@ | |||
| @echo "CXX <= $<" | |||
|
|
|||
| Enclave/%.o: Enclave/%.cpp | |||
| Enclave/%.o: Enclave/%.cpp Enclave/enclave_hsm_t.c | |||
|
Oh, sorry, I update it currently, please see newest commit I find above BUGs via fuzzing and sanitizer, thus may not so familiar with code context |
yang8621
reviewed
Jun 7, 2023
core/Makefile
Outdated
| @@ -203,11 +203,13 @@ Enclave/enclave_hsm_t.c: $(SGX_EDGER8R) Enclave/enclave_hsm.edl | |||
| @cd Enclave && $(SGX_EDGER8R) --trusted ../Enclave/enclave_hsm.edl --search-path ../Enclave --search-path ../Enclave/self_test --search-path $(SGX_SDK)/include --search-path $(OPENSSL_PATH)/include | |||
| @echo "GEN => $@" | |||
|
|
|||
| Enclave/enclave_hsm_t.h: Enclave/enclave_hsm_t.c | |||
There was a problem hiding this comment.
Thanks. Our existing codes are not standard. Could we change Line 202 to:
Enclave/enclave_hsm_t.h : .....
And update your line to:
Enclave/enclave_hsm_t.c: Enclave/enclave_hsm_t.h
There was a problem hiding this comment.
I've updated commit
yang8621
approved these changes
Jun 7, 2023
syan10
approved these changes
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.