Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPGA: Drop OpenCL UUID bitstream validation #1643

Merged
merged 1 commit into from
Jan 12, 2024
Merged

FPGA: Drop OpenCL UUID bitstream validation #1643

merged 1 commit into from
Jan 12, 2024

Conversation

eliaskoromilas
Copy link
Member

fixes #1642

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7f8bebd) 51.89% compared to head (a19fb2e) 51.94%.
Report is 8 commits behind head on main.

❗ Current head a19fb2e differs from pull request most recent head 18531bd. Consider uploading reports for the commit 18531bd to get more accurate results

Files Patch % Lines
pkg/controllers/qat/controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   51.89%   51.94%   +0.05%     
==========================================
  Files          42       42              
  Lines        4916     4911       -5     
==========================================
  Hits         2551     2551              
+ Misses       2215     2210       -5     
  Partials      150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, please comment out the check and add a TODO about verifying it.

Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
Copy link
Member

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@mythi mythi merged commit e673ca9 into intel:main Jan 12, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FPGA: Issue with .aocx bitstream parser
6 participants