Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator: add support for tolerations and add differentiation labels #1686

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Operator: add support for tolerations and add differentiation labels #1686

merged 2 commits into from
Mar 21, 2024

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Mar 12, 2024

Fixes #1676
Fixes #1617

@tkatila
Copy link
Contributor Author

tkatila commented Mar 12, 2024

@hj-johannes-lee I wasn't able to test the operatorhub change (label add) locally. Do you know if there's a way to do it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024 •
edited

Codecov Report

Attention: Patch coverage is 59.15493% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 39.88%. Comparing base (7d00cf0) to head (1003eda).
Report is 13 commits behind head on main.

❗ Current head 1003eda differs from pull request most recent head 6a4434b. Consider uploading reports for the commit 6a4434b to get more accurate results

Files Patch % Lines
pkg/apis/deviceplugin/v1/zz_generated.deepcopy.go 0.00% 37 Missing ⚠️
cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go 33.33% 11 Missing and 1 partial ⚠️
pkg/controllers/dlb/controller.go 0.00% 4 Missing and 1 partial ⚠️
pkg/controllers/dsa/controller.go 0.00% 4 Missing and 1 partial ⚠️
pkg/controllers/fpga/controller.go 0.00% 4 Missing and 1 partial ⚠️
pkg/controllers/gpu/controller.go 0.00% 3 Missing and 2 partials ⚠️
pkg/controllers/iaa/controller.go 0.00% 4 Missing and 1 partial ⚠️
pkg/controllers/qat/controller.go 0.00% 4 Missing and 1 partial ⚠️
pkg/controllers/sgx/controller.go 0.00% 4 Missing and 1 partial ⚠️
cmd/gpu_plugin/device_props.go 92.59% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
+ Coverage   39.67%   39.88%   +0.21%     
==========================================
  Files          73       75       +2     
  Lines        6520     6651     +131     
==========================================
+ Hits         2587     2653      +66     
- Misses       3782     3840      +58     
- Partials      151      158       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hj-johannes-lee
Copy link
Contributor

@tkatila I tested just by pushing the image to dockerhub (private). Locally, you need to have local registry which I gave up after a few times of attempts..!

mythi
mythi reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can Fixes: #1571 too

pkg/controllers/fpga/controller_test.go Outdated Show resolved Hide resolved
pkg/apis/deviceplugin/v1/qatdeviceplugin_types.go Outdated Show resolved Hide resolved
@mythi
Copy link
Contributor

mythi commented Mar 15, 2024

I believe this can Fixes: #1571 too

Oops, not sure how I thought it was still open. Nevermind about this comment

@tkatila
Add tolerations support to operator and plugin CRDs
52be7ed 
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
@tkatila
operator: add differentiation label
6a4434b 
Add one device plugin specific label to differentiate our operator
from all the possible operators within same namespace.

Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
@mythi mythi merged commit 61e38e0 into intel:main Mar 21, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eero-t eero-t eero-t left review comments

@mythi mythi mythi approved these changes

@hj-johannes-lee hj-johannes-lee Awaiting requested review from hj-johannes-lee hj-johannes-lee is a code owner

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@ozhuraki ozhuraki Awaiting requested review from ozhuraki ozhuraki is a code owner

@kad kad Awaiting requested review from kad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@tkatila @codecov-commenter @hj-johannes-lee @mythi @eero-t