Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qat: make users explicitly opt in to have kernel mode compiled in #204

Merged
merged 4 commits into from
Aug 19, 2019
Merged

qat: make users explicitly opt in to have kernel mode compiled in #204

merged 4 commits into from
Aug 19, 2019

Conversation

rojkov
Copy link
Contributor

@rojkov rojkov commented Aug 12, 2019

No description provided.

@rojkov rojkov requested review from bart0sh and kad August 12, 2019 13:01
@codecov-io
Copy link

codecov-io commented Aug 12, 2019 •
edited
Loading

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   79.17%   79.17%           
=======================================
  Files          11       11           
  Lines        1508     1508           
=======================================
  Hits         1194     1194           
  Misses        281      281           
  Partials       33       33
Impacted Files Coverage Δ
cmd/qat_plugin/kerneldrv/kerneldrv.go 75.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9b19d...a2debf6. Read the comment docs.

@mythi
Copy link
Contributor

mythi commented Aug 12, 2019

@rojkov thanks! this what I was thinking. let's hear from @kad and @bart0sh what they have to say about using tags.

@rojkov
Copy link
Contributor Author

rojkov commented Aug 14, 2019

@bart0sh I've updated Makefile not to use build tags by default, please have another review round.

@kad
Copy link
Member

kad commented Aug 14, 2019

Why do we want this? Also, can we have updated documentation for qat plugin to mention those build options with description?

@mythi
Copy link
Contributor

mythi commented Aug 14, 2019

@kad we want this to be able to ship without kernerdrv (and it's dependencies in the container) while still keeping that functionality in the repo.

@kad
Copy link
Member

kad commented Aug 15, 2019

@mythi so, can we have documentation update that will describe that build mode?

@mythi
Copy link
Contributor

mythi commented Aug 15, 2019

@kad sure, I'll help with that. FWIW, we also have #197

@rojkov
Copy link
Contributor Author

rojkov commented Aug 16, 2019

Added documentation update by Mikko.

@mythi
Copy link
Contributor

mythi commented Aug 17, 2019

Jenkinsfile needs updating too for make test

Dmitry Rozhkov and others added 2 commits August 19, 2019 09:56
use BUILDTAGS=kerneldrv in CI
cda77f5
@mythi
qat: document kerneldrv mode and build instructions
d92b528 
-mode kerneldrv comes with no documentation. This patch adds few
notes about it and instructions how to get it build if a user chooses
to have it enabled.

Closes: intel#197

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@rojkov
Copy link
Contributor Author

rojkov commented Aug 19, 2019

Updated Jenkinsfile.

mythi
mythi previously approved these changes Aug 19, 2019
View reviewed changes
kad
kad approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks.

@kad kad merged commit b7263fa into intel:master Aug 19, 2019
askervin pushed a commit to askervin/intel-device-plugins-for-kubernetes that referenced this pull request May 6, 2020
@marquiz
Merge pull request intel#204 from kad/update-golangci-lint
870bfb8 
Update golangci-lint to v1.23.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kad kad kad approved these changes

@mythi mythi mythi left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rojkov @codecov-io @mythi @kad