Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

part 2 of the distroless/static move #636

Merged
merged 1 commit into from
Jun 2, 2021
Merged

part 2 of the distroless/static move #636

merged 1 commit into from
Jun 2, 2021

Conversation

mythi
Copy link
Contributor

@mythi mythi commented May 18, 2021 •
edited

Closes: #516

@mythi
Copy link
Contributor Author

mythi commented May 19, 2021 •
edited

TODO

  • intel-vpu-plugin
  • copy toybox/musl license

@msivosuo msivosuo added this to In progress in 2021-6 via automation May 19, 2021
@mythi mythi force-pushed the PR-2021-031 branch 2 times, most recently from e602f48 to 1b309e4 Compare May 19, 2021 17:45
rojkov
rojkov previously approved these changes May 26, 2021
View reviewed changes
@mythi mythi changed the title WIP: part 2 of the distroless/static move part 2 of the distroless/static move May 28, 2021
@mythi mythi marked this pull request as ready for review May 28, 2021 05:05
@mythi mythi requested a review from kad as a code owner May 28, 2021 05:05
@mythi
Copy link
Contributor Author

mythi commented May 28, 2021

@bart0sh @rojkov this is now ready

rojkov
rojkov previously approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@rojkov rojkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build/docker/intel-fpga-initcontainer.Dockerfile Show resolved Hide resolved
@mythi mythi mentioned this pull request Jun 1, 2021
Merged
@mythi
images: update initcontainers and VPU plugin to new base images
7000d30 
This is the part 2 of the work to move our published container images
to new base images. The initcontainers will be based on
distroless/static and the VPU plugin is based on Debian.

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
bart0sh
bart0sh approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bart0sh bart0sh merged commit 47f5b34 into intel:main Jun 2, 2021
2021-6 automation moved this from In progress to Done Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh bart0sh approved these changes

@rojkov rojkov rojkov left review comments

@kad kad Awaiting requested review from kad kad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2021-6
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move to static and stripped binaries, use distroless
3 participants
@mythi @rojkov @bart0sh