Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing documentation in LLM runtime, and a broken link + some typos #1128

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Fix missing documentation in LLM runtime, and a broken link + some typos #1128

merged 3 commits into from
Jan 11, 2024

Conversation

aahouzi
Copy link
Member

@aahouzi aahouzi commented Jan 10, 2024

Type of Change

  • Fix missing documentation in LLM runtime, and a broken link + some typos

Description

  • User needs to install the dependencies in requirements.txt, not only in Transformer-based API option but also when running the Straightforward Python script option, otherwise the convert.py throws an error of many missing packages.
  • Fix a broken link of Python script option: When clicking on it doesn't take you to the right part in the README.
  • Fix typos in run.py script.

Expected Behavior & Potential Risk

N/A

How has this PR been tested?

Any HW

Dependency Change?

N/A

airMeng
airMeng approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for nice catching!

zhenwei-intel
zhenwei-intel approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@zhenwei-intel zhenwei-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinintel kevinintel merged commit f780a28 into intel:main Jan 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airMeng airMeng airMeng approved these changes

@zhenwei-intel zhenwei-intel zhenwei-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aahouzi @airMeng @zhenwei-intel @kevinintel