Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs have no SONAME #51

Closed
tjaalton opened this issue Feb 7, 2019 · 5 comments
Closed

libs have no SONAME #51

tjaalton opened this issue Feb 7, 2019 · 5 comments
Assignees

Comments

@tjaalton
Copy link

tjaalton commented Feb 7, 2019

The produced libs have no SONAME, please fix that so that distros can ship proper packages.

@chivakker
Copy link

Please do fix this, but also please explain how you're going to make compatibility work with different versions of dependencies, it would be good if you guys can describe the full picture.

@iwwu
Copy link
Contributor

iwwu commented Feb 14, 2019

Among our list of .so libraries, libcommon_clang.so has SONAME set. I'll look into adding this field to other libraries
libiga.so
libigc.so
libigdfcl.so
libopencl_clang.so

@iwwu iwwu self-assigned this Feb 15, 2019
@nandojve
Copy link

I had problems to build NEO because of IGC libraries.

  1. When a shared library isn't found, ocloc abort without any error message. Please, when load shared library check properly and print/log error message to help users.
  2. Library names isn't right: Can't build runtime/built_ins/kernels compute-runtime#133
    Please, use the right denomination to all libraries:
LINK          22 Feb 19 21:13 libcommon_clang.so -> libcommon_clang.so.7.1
SONAME        22 Feb 19 21:13 libcommon_clang.so.7 -> libcommon_clang.so.7.1
LIBRARY 73373504 Feb 18 20:17 libcommon_clang.so.7.1

I believe this small improvement could help a lot.

@tripzero
Copy link

#74 fixes this issue.

VPG-SWE-Github pushed a commit that referenced this issue Mar 14, 2019
Change-Id: Id0ce987ded711c85ba9b048b4b55627a7bd8e5c6
@paigeale
Copy link
Contributor

Closing. Issue fixed with 3cc1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants