Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible executable stack in shared library #18

Closed
ColinIanKing opened this issue Mar 1, 2018 · 3 comments
Closed

Possible executable stack in shared library #18

ColinIanKing opened this issue Mar 1, 2018 · 3 comments
Labels

Comments

@ColinIanKing
Copy link
Contributor

When packaging the library for Debian/Ubuntu the lintian checker reports that the shared library stack is executable. The lintian warning is: shlib-with-executable-stack as follows:

"The listed shared library declares the stack as executable.

Executable stack is usually an error as it is only needed if the code contains GCC trampolines or similar constructs which uses code on the stack. One possible source for false positives are object files built from assembler files which don't define a proper .note.GNU-stack section.

To see the permissions on the stack, run readelf -l on the shared library and look for the program header of type GNU_STACK. In the flag column, there should not be an E flag set."

I was wondering if this can be investigated and fixed

@tkanteck
Copy link
Contributor

tkanteck commented Mar 1, 2018

Thanks for reporting the problem. Since C compiler flags disable stack execution so the problem must be related to assembly files. I'll investigate the problem.

tkanteck added a commit that referenced this issue Mar 5, 2018
…ry file

Change-Id: Ie4d7b872b34e83326941ac5d84f3b3ed13d17663
@tkanteck
Copy link
Contributor

tkanteck commented Mar 5, 2018

I believe this patch fixes the problem. Feel free to reopen if required.
Thanks!

@tkanteck tkanteck closed this as completed Mar 5, 2018
@ColinIanKing
Copy link
Contributor Author

Thanks, this fixes the issue for me and I've uploaded the fixed packed to Debian/Ubuntu.

@tkanteck tkanteck added the bug label Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants