Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite RewriteTensorPointer pass to support 2D block store #1143

Closed
whitneywhtsang opened this issue May 17, 2024 · 4 comments · Fixed by #1193
Closed

Rewrite RewriteTensorPointer pass to support 2D block store #1143

whitneywhtsang opened this issue May 17, 2024 · 4 comments · Fixed by #1193
Assignees
@mfrancepillois
Labels
codegen: dpas enhancement New feature or request performance
Milestone
4.0 [Performance]...

Comments

@whitneywhtsang
Copy link
Contributor

Similar to #958 but for 2D block store.
@chengjunlu
Copy link
Contributor

chengjunlu commented May 17, 2024 •
edited
Loading

Add 2D store hardware support in the fall back pass pipeline for kernel with tt.dot.

Note: The PoC achieve this by three steps.
It first require to forward propagate the DPAS layout to the store ops. And remove redundant layout convert op.
18a1892

Materialized the tt.store with the data operands with the DPAS layout to triton_intel.store_2d
fed0b81

And finally add the lowering from 'triton_intel.store_2d' to Intel 2D store.
79a57bd

The product code flow may be different in the 2nd step.

This was referenced May 17, 2024
Closed
Closed
@vlad-penkin vlad-penkin added the enhancement New feature or request label May 20, 2024
@vlad-penkin vlad-penkin added this to the 4.1 [Performance] DPAS milestone May 20, 2024
@mfrancepillois mfrancepillois self-assigned this May 22, 2024
mfrancepillois added a commit that referenced this issue May 27, 2024
@mfrancepillois
Rewrite RewriteTensorPointer pass to support 2D block store
1120ded 
Prevents StoreOp from being rewritten if it is not suitable for 2D store.

Addresses Issue: #1143

Signed-off-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
@mfrancepillois mfrancepillois mentioned this issue May 27, 2024
Merged
@vlad-penkin vlad-penkin linked a pull request May 28, 2024 that will close this issue
Rewrite RewriteTensorPointer pass to support 2D block store #1193
Merged
@mfrancepillois
Copy link
Contributor

The PR has been approved, but the CIs are failing. We are investigating to find out the reason.

@mfrancepillois
Copy link
Contributor

A few bugs have been fixed in the block store 2D support, however the CIs of the last PR still fail. The values seem not to be written to the right position in the buffer. Investigation in progress.

@chengjunlu chengjunlu mentioned this issue Jun 24, 2024
Closed
@mfrancepillois
Copy link
Contributor

CI failures on PR #1193 seem unrelated to the PR.
So, IMO the PR is ready be merged.

etiotto pushed a commit that referenced this issue Jun 24, 2024
@mfrancepillois
Rewrite RewriteTensorPointer pass to support 2D block store (#1193)
8416c31 
Prevents `StoreOp`s from being rewritten if it is not suitable for 2D
block store.

Addresses Issue: #1143

---------

Signed-off-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfrancepillois mfrancepillois

Labels
codegen: dpas enhancement New feature or request performance
Projects
None yet
Milestone
4.0 [Performance] Core
Development

Successfully merging a pull request may close this issue.

Rewrite RewriteTensorPointer pass to support 2D block store intel/intel-xpu-backend-for-triton
5 participants
@whitneywhtsang @etiotto @chengjunlu @vlad-penkin @mfrancepillois