ledctl: add error message for missing devices #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #213 |
ktanska
approved these changes
Mar 28, 2024
mtkaczyk
requested changes
Mar 28, 2024
Ledctl prints error message for not supported devices, but there is no such message for not existent or missing devices. Add error message for missing devices for consistency. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
mku514k
force-pushed
the
mkus-unify-errors
branch
2 times, most recently
from
b58ba4e
to
9bb7923
Compare
mtkaczyk
requested changes
Apr 9, 2024
Add universal_newlines=True and shell=True for subprocess.run() call in run_led_cmd(). With universal_newlines decoding to utf-8 is not needed. Without shell param returncodes and some output lines are omitted. Change run_ledctl_cmd_decode() to run_ledctl_cmd_valid(). It returns stdout only, raise exception if non zero status is returned. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
Add tests for checking output for not existing and unsupported devices. Add run_ledctl_cmd_not_valid() function for checking negative scenarios. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
mku514k
force-pushed
the
mkus-unify-errors
branch
from
9bb7923
to
342a1ea
Compare
mtkaczyk
approved these changes
Apr 9, 2024
ktanska
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ledctl prints error message for not supported devices, but there is no such message for not existent or missing devices.
Add error message for missing devices for consistency.