Don't build with -Werror #48
Conversation
New compiler versions might output new warnings by default (see #47 for an example), which makes -Werror problematic for distributions. The more specific -Werror= settings are usually not a problem. The warnings are still shown, but they will no longer break the build. Signed-off-by: Adrian Bunk <bunk@debian.org>
|
I would prefer #47 to be fixed instead of disabling this flag. Are you ok to wait for proper solution or is this blocking release process in Debian? Regards, |
|
You need both. These warnings are useful for you as upstream to improve your code, and you should fix #47. When distributions will switch to gcc 10 (or any other later compiler) there might be yet other new warnings, and it is a pain for distributions when software builds with -Werror which makes new warnings for old code fatal. In practice the result are usually quick hacks just to silence the warning by people who neither know nor use your code - this often creates more bugs than it fixes. That's why the warnings are useful, but they shouldn't be errors. |
|
The usual and recommended practice is to enable -Werror only on CI/development builds, and disable everywhere else. Otherwise, releases will keep breaking for reasons outside your control. On the other hand, -Werror=a-specific-warning is safe. |
|
@mdabrows: Debian packaging can carry arbitrary patches above upstream sources, thus it's not a show stopper. It is much preferred to submit all patches upstream, though. |
|
Hello, After internal discussion this change can be accepted and we will improve our CI to keep benefits of Regards, |
New compiler versions might output new warnings by default
(see #47 for an example), which makes -Werror problematic
for distributions.
The more specific -Werror= settings are usually not a problem.
The warnings are still shown, but they will no longer break
the build.
Signed-off-by: Adrian Bunk bunk@debian.org