build failure when x11 support is disabled

[anujm1]

The sfc sample added in 2.4.0 doesn't build when USE_X11 is false. It should have skipped compiling this sample.

[solabc16]

Hello

I've just come across this too, configuring explicitly with the following...

./configure             \
    --prefix=<somepath> \
    --enable-shared     \
    --disable-static    \
    --disable-x11       \
    --disable-wayland   \
    --disable-tests

... yields ...

VDecAccelVA.h:42:10: fatal error: X11/Xlib.h: No such file or directory
 #include <X11/Xlib.h>
          ^~~~~~~~~~~~
compilation terminated.

Best
-James

[solabc16]

As a 'quick fix' you can edit Makefile.am as follows...

Original

SUBDIRS = common decode encode vainfo videoprocess vendor/intel vendor/intel/sfcsample

if USE_X11
SUBDIRS += putsurface
else
if USE_WAYLAND
SUBDIRS += putsurface
endif
endif

Modified

SUBDIRS = common decode encode vainfo videoprocess vendor/intel

if USE_X11
SUBDIRS += putsurface vendor/intel/sfcsample
else
if USE_WAYLAND
SUBDIRS += putsurface
endif
endif

Make sure to run autoreconf -fiv before you run configure.

Best
- James

[driesmp]

Hi guys, stumbled upon this bug too. Can this get fixed please?

[jonozzz]

The fix, translated into a patch would be:

--- Makefile.am.orig    2019-04-18 06:40:11.621443043 +0000
+++ Makefile.am 2019-04-18 06:40:26.605537495 +0000
@@ -24,10 +24,10 @@

 AUTOMAKE_OPTIONS = foreign

-SUBDIRS = common decode encode vainfo videoprocess vendor/intel vendor/intel/sfcsample
+SUBDIRS = common decode encode vainfo videoprocess vendor/intel

 if USE_X11
-SUBDIRS += putsurface
+SUBDIRS += putsurface vendor/intel/sfcsample
 else
 if USE_WAYLAND
 SUBDIRS += putsurface

Thanks @solabc16 for figuring it out.

[uartie]

Is #159 a better fix?

[uartie]

Is #159 a better fix?

Hmmm... maybe not. #include <X11/Xlib.h> is still in the header file.

[uartie]

AFAICT, sfcsample does not use X11 anywhere... so the inclusion of X11 headers is cruft.

[uartie]

@kanghuaz