Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

va/va_trace: unbreak Linux with glibc >= 2.30 #461

Merged
merged 1 commit into from
Oct 16, 2020
Merged

va/va_trace: unbreak Linux with glibc >= 2.30 #461

merged 1 commit into from
Oct 16, 2020

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Oct 16, 2020

Regressed by 9ab7db3 and glibc@1d0fc213824e and musl@d49cf07541bb.
Fixes #363 (comment).

TravisCI + dist: focal results: before, after.

@jbeich
va/va_trace: ignore system gettid() on Linux
9850109 
glibc could probably use `__GLIBC_PREREQ(2, 30)` but musl doesn't
expose version to consumers. Instead of dancing around various libc
always use local definition.
@jbeich jbeich changed the title va/va_trace: ignore system gettid() on Linux va/va_trace: unbreak Linux with glibc >= 2.30 Oct 16, 2020
@dvrogozh
Copy link
Contributor

@uartie : was Fedora build issue same as on Ubuntu?

@dvrogozh
Copy link
Contributor

Works for me on Ubuntu 20.04.

@dvrogozh dvrogozh requested a review from uartie October 16, 2020 19:11
@dvrogozh
Copy link
Contributor

Works for me on Fedora 32 as well.

@dvrogozh dvrogozh merged commit 0ed447d into intel:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh approved these changes

@uartie uartie Awaiting requested review from uartie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbeich @dvrogozh