wayland: don't try to authenticate with render nodes #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XinfengZhang: gentle ping |
|
sorry for late response, 1 question: is there minimum version requirement for function drmGetNodeTypeFromFd? |
When the parent compositor is running with a render node, Mesa will send the render node path via wl_drm instead of the primary path. DRM authentication doesn't work with render nodes. This patch makes the Wayland logic consistent with the DRM logic [1]. Tested using Sway running with wlroots' headless backend. [1]: https://github.com/intel/libva/blob/b4d0af7f43f0ef2d51f070c75429c0d6acca663b/va/drm/va_drm.c#L68 Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
wl-render-nodes
branch
from
2a7d63a
to
a04d663
Compare
|
That's a good point, it requires 2.4.60. I've updated the patch to bump to version constraint. |
|
Ping @XinfengZhang |
1 similar comment
|
Ping @XinfengZhang |
XinfengZhang
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parent compositor is running with a render node, Mesa will send
the render node path via wl_drm instead of the primary path. DRM
authentication doesn't work with render nodes.
This patch makes the Wayland logic consistent with the DRM logic 1.
Tested using Sway running with wlroots' headless backend.
Signed-off-by: Simon Ser contact@emersion.fr