Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attributes to report dynamic resolution support #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XinfengZhang
Copy link
Contributor

Signed-off-by: Carl Zhang carl.zhang@intel.com

Signed-off-by: Carl Zhang <carl.zhang@intel.com>
@@ -1028,6 +1028,13 @@ typedef enum {
* The value returned uses the VAConfigAttribValEncPerBlockControl type.
*/
VAConfigAttribEncPerBlockControl = 55,
/** \brief dynamic resolution change support. Read-only.
*
* This attributes describes whether backend driver support dynamic resolution change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the grammar: This attribute(-s) describes whether the backend driver supports(+s)...indicate whether needing to reset context.

*
* 0: invalid value
* 1: need to reset context for drc
* 2: could not reset context for drc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to indicate "In this case, context resolution will not limit runtime surface resolution."

* 1: need to reset context for drc
* 2: could not reset context for drc
*/
uint32_t drc_context_reset : 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 bits are enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants