Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VAProfileH264High10 #664

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

gitgjogh
Copy link

@gitgjogh gitgjogh commented Dec 14, 2022

Signed-off-by: jianfeng.zheng jianfeng.zheng@mthreads.com

@gitgjogh gitgjogh force-pushed the VAProfileH264High10 branch 4 times, most recently from c027ff4 to 95ced16 Compare December 14, 2022 09:17
Copy link
Contributor

@XinfengZhang XinfengZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we dont need the VA_PROFILE_H264_HIGH_10, please remove it, driver could determine whether report such profile.
and , is it convenient to share which driver will support high 10 profile, enc or dec?

va/va.h Outdated Show resolved Hide resolved
@gitgjogh gitgjogh force-pushed the VAProfileH264High10 branch 5 times, most recently from bb0d700 to 5957742 Compare December 14, 2022 15:22
@evelikov
Copy link
Contributor

Do we have an idea which drivers will support this profile - any of the Intel ones (i965, iHD), mesa (radeonsi, nouveau) or some other?

More importantly - I think we need to update the tests, right?

@gitgjogh
Copy link
Author

Do we have an idea which drivers will support this profile - any of the Intel ones (i965, iHD), mesa (radeonsi, nouveau) or some other?

I'm now working for Moore Threads. Moore Threads (short for Mthreads) is a Chinese GPU manufacturer. Our newest products, MTTS80/MTTS2000/MTT3000, all has H264High10 enc/dec capabilities at max 8k resolution.

Beside H264High10, our produncts also support AVS+ and AVS2 video decoding that are now all out of VAAPI definition. And we also wish to add them to VAAPI.

More importantly - I think we need to update the tests, right?

For H264High10, since only enum VAProfileHigh10 has been added, I think it may not need to test for LIBVA. Rather, MediaDriver and uplayer application like gstreamer or FFMpeg need to be test. We actually has bring up both decoding and encoding wok flow under FFmpeg and test under vaapi-fits.

@evelikov
Copy link
Contributor

evelikov commented Dec 18, 2022

The test suite in libva-utils will also need small changes. See my comment in intel/libva-utils#274 for some pointers.

Adding ffmpeg and vaapi-fits support sounds amazing, thank you \o/

@gitgjogh
Copy link
Author

hi evelikov,

intel/libva-utils#298 has been created.

gitgjogh pushed a commit to gitgjogh/libva-utils that referenced this pull request Dec 20, 2022
see [intel/libva#664](intel/libva#664)

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/libva-utils that referenced this pull request Dec 20, 2022
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Dec 25, 2022
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Dec 25, 2022
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Dec 27, 2022
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Dec 27, 2022
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
@gitgjogh
Copy link
Author

gitgjogh commented Dec 27, 2022 via email

Copy link
Contributor

@XinfengZhang XinfengZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
@gitgjogh
Copy link
Author

gitgjogh commented Jan 5, 2023 via email

@XinfengZhang XinfengZhang merged commit b75818c into intel:master Jan 5, 2023
@gitgjogh gitgjogh deleted the VAProfileH264High10 branch January 6, 2023 06:59
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 8, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 8, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 8, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 8, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 9, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
XinfengZhang pushed a commit to intel/libva-utils that referenced this pull request Mar 17, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Mar 29, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
xhaihao pushed a commit to xhaihao/ffmpeg-1 that referenced this pull request Apr 14, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
xhaihao pushed a commit to xhaihao/ffmpeg-1 that referenced this pull request Apr 14, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
xhaihao pushed a commit to xhaihao/ffmpeg-1 that referenced this pull request Apr 17, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
xhaihao pushed a commit to xhaihao/ffmpeg-1 that referenced this pull request Apr 17, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
BtbN pushed a commit to FFmpeg/FFmpeg that referenced this pull request Apr 17, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
BtbN pushed a commit to FFmpeg/FFmpeg that referenced this pull request Apr 17, 2023
see intel/libva#664

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants